Trim paragraph margins at the bottom of tab panels#175
Open
benjaoming wants to merge 1 commit intoexecutablebooks:masterfrom
Open
Trim paragraph margins at the bottom of tab panels#175benjaoming wants to merge 1 commit intoexecutablebooks:masterfrom
benjaoming wants to merge 1 commit intoexecutablebooks:masterfrom
Conversation
|
Thanks for submitting your first pull request! You are awesome! 🤗 |
Author
|
Just noticed #143 - the implementation there wouldn't work for panels with several paragraphs. |
benjaoming
commented
Jan 26, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 97.27% 97.27%
=======================================
Files 2 2
Lines 220 220
=======================================
Hits 214 214
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change affects all themes, however the behavior may also be visually problematic in several themes. I only just noticed it in sphinx-rtd-theme.
Themes that aren't affected probably also aren't affected by the margin change, since in this case they probably don't put margins under
pelements.As I understand
sphinx-tabs-panel p:last-child, it will trigger if that particular<p>element is the last of all child elements in the tabs panel. So that should work as intended.Before:
After: